Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ISSUE-6220 #6222

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix ISSUE-6220 #6222

merged 1 commit into from
Mar 20, 2020

Conversation

Swedish-li
Copy link
Contributor

parse font property (start with font size) error

@Swedish-li
fix ISSUE-6220
f02d2ac 
font property (start with font size)error
@Swedish-li Swedish-li mentioned this pull request Mar 18, 2020
Closed
@asturur
Copy link
Member

asturur commented Mar 19, 2020

Thanks for the PR.
Do you have any link to the specs for the css font attribute on svg?
It should be the same as standard html, but better check.

@Swedish-li
Copy link
Contributor Author

Swedish-li commented Mar 19, 2020 •
edited
Loading

this is the same as css specs.

Except for any additional information provided in this specification, the normative definition of the property is in CSS2 ([CSS2], section 15.2.5).

https://www.w3.org/TR/SVG11/text.html#FontFamilyProperty

The ‘style’ element allows style sheets to be embedded directly within SVG content. SVG's ‘style’ element has the same attributes as the corresponding element in HTML.

https://www.w3.org/TR/SVG2/styling.html

@asturur
Copy link
Member

asturur commented Mar 20, 2020

well seems fine to me then! Thanks.

@asturur asturur merged commit f9648fc into fabricjs:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swedish-li @asturur